Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix depth projection with ControlNet #717

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Fix depth projection with ControlNet #717

merged 1 commit into from
Oct 28, 2023

Conversation

carson-katri
Copy link
Owner

This resolves the following issues with texture projection:

  1. Incorrect error reporting -- updated to use the revised FixItError type
  2. ControlNet being ignored when no image associated. This conditional check was incorrect, as control_images are now passed in as a separate argument.

@carson-katri carson-katri linked an issue Oct 28, 2023 that may be closed by this pull request
SDXL with ControlNet does not respond to depth #712
Closed
@carson-katri carson-katri merged commit 9927174 into releases/0.3.0 Oct 28, 2023
@carson-katri carson-katri mentioned this pull request Oct 28, 2023
Closed
carson-katri added a commit that referenced this pull request Nov 4, 2023
@carson-katri
Release v0.3.0 (#711)
4f210c5 
* Bump version #

* Ensure refiner is not None when loading in prompt_to_image (#716)

* Fix depth projection with ControlNet (#717)

* Add workaround for AutoPipeline.from_pipe with ControlNet (#720)

* Upgrade diffusers and remove workaround (#721)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDXL with ControlNet does not respond to depth
1 participant
@carson-katri